search

catppuccin / ida-debugger

🐞Soothing pastel theme for IDA (Interactive Disassembler)
MIT License
32 stars 2 forks source link

Readability issues #3

Open EmiMidnight opened 1 year ago

EmiMidnight commented 1 year ago

Hey there, theme looks very cozy but there's at least two spots that are pretty bad contrast wise currently.

Lines with active breakpoints are completely unreadable on all 4 color variants: image

Clicking on a highlighted line/variable in the structure view is not completely unreadable, but still bad contrast wise I think: image

Otherwise, everything else looks great over here. :)

naldrv commented 1 year ago

Agreed. Breakpoints should probably use color-red with some added transparency.

Here are the properties that would require changing:

qproperty-line-bg-bpt-enabled: ${color-teal}; /* switch to color-red and add transparency */

/* i am unsure what these properties would look like, maybe add transparency to them as well? */
qproperty-line-bg-bpt-disabled: ${color-text};
qproperty-line-bg-bpt-unavailable: ${color-overlay0};

The variable highlight is causing readability issues because it's actually layering it's transparency with the current-line highlight. Would probably be better to switch to using a different color entirely for variable highlights. I'll put a PR together for this.

naldrv commented 1 year ago

I added more transparency to the cursor line background color and switched the highlight background color to maroon, as well as adding more transparency.

I also think this looks much better for breakpoints (red with 30% transparency):

EmiMidnight commented 1 year ago

Looks great! 🙏

I noticed one more issue, in the type declaration editor, the offset is invisible. image

I added 

TextEdit QWidget {
    background-color: transparent;
}

and that seems to have fixed it. Not sure if that causes any other changes I didn't notice.