Detect if Catppuccin Theme is installed and switch icon pack automatically

catppuccin / jetbrains-icons

🦊 Soothing pastel icons for JetBrains IDEs

https://plugins.jetbrains.com/plugin/23029-catppuccin-icons

MIT License

112 stars 11 forks source link

Detect if Catppuccin Theme is installed and switch icon pack automatically #10

Open zzhaolei opened 1 year ago

zzhaolei commented 1 year ago

I use catppuccin mocha.

Goland Dark Theme:

Goland Light Theme:

Can we have mixed modes? No need to switch icons every time.

ricardoboss commented 11 months ago

A way to set an icon pack for light and an icon pack for dark mode would be nice. I am using Auto Dark Mode and my IDE switches themes automatically. I'd rather not restart my IDE every time my theme changes.

quentinguidee commented 11 months ago

Can we have mixed modes? No need to switch icons every time.

I don't think that mixed mode will be implemented one day in the official icons pack. A fork could do that, but I don't think we want to go against the guidelines here + it will be better to spend the efforts for implementing hot-reload.

A way to set an icon pack for light and an icon pack for dark mode would be nice. I am using Auto Dark Mode and my IDE switches themes automatically. I'd rather not restart my IDE every time my theme changes.

For that unfortunately we still need to figure out before how to do dynamic reload. Before that even if we implement theme sync you'll still need to restart.

sgoudham commented 3 months ago

I think a mixed-mode will be an absolute last resort for this plugin as we already have the functionality to switch icon packs between the different flavours. As @quentinguidee mentions above, hopefully we can implement some logic that detects if the Catppuccin Theme is installed, automatically switch to the correct icon pack and prompt the user to restart.

I believe you will still need to restart the IDE but probably worth looking at other Icon plugins to see if they have the ability to change the icons dynamically without restarting.

huxxcb commented 2 months ago

I believe you will still need to restart the IDE but probably worth looking at other Icon plugins to see if they have the ability to change the icons dynamically without restarting.

I know the Atom Material Icons pack supports hot swapping, might be worth a look.

sgoudham commented 2 months ago

I know the Atom Material Icons pack supports hot swapping, might be worth a look.

Yeah that's something that I'm personally aware of but don't have the time to sink into understanding the codebase and their loading strategy as it's a lot more complex than ours. I'd totally appreciate if someone else wants to take a look and list their findings here on how we can adopt hot-reloadable icons or even make a PR for it!

I don't believe @thelooter or @quentinguidee have the time to look at this plugin at the moment.