catppuccin / jetbrains

🧠 Soothing pastel theme for JetBrains IDEs
https://plugins.jetbrains.com/plugin/18682
MIT License
374 stars 34 forks source link

Latte theme: Very low contrast of highlighted search terms in the Search Everywhere window #123

Closed t-bowersox closed 1 month ago

t-bowersox commented 7 months ago

Is there an existing issue outlining your problem?

Have you followed the instructions in the the pinned issue?

Describe your problem.

When you have the Latte theme applied, open the "Search Everywhere" window (i.e. pressing Shift twice) and start searching for something.

You should notice that the highlighted matches in the search results have very low contrast and are hard to read.

I checked the colors from the screenshot in the WebAIM contrast checker and the ratio is only 1.41:1. Ideally, the contrast ratio should be 4.5:1.

Attach screenshots.

Screenshot 2024-02-26 at 2 22 21 PM

What IDE(s) are you seeing the problem on?

WebStorm 2023.3.4

Any additional comments?

No response

sgoudham commented 7 months ago

Hey :wave:

Thanks for raising this, I've tried to fix this myself earlier in previous versions and wasn't able to modify it :(

I'll try again later but I distinctly remember the on hover highlight not being in our control.

enidisepic commented 7 months ago

I looked into this and it is indeed not possible to change the foreground color of SearchMatch. However, if that is a possible change, other background colors would offer a higher contrast ratio:

Color(s) Example Contrast Ratio
Yellow Example 3.05
Rosewater, Pink Example Example 3.02
Click here for the other colors Colors that have been omitted: | Color(s) | Example | Contrast Ratio | |--------|--------|--------| | Sky | ![Example](https://place-hold.it/50/04a5e5/4c4f69.png?text=test) | 2.85 | | Flamingo, Peach | ![Example](https://place-hold.it/50/dd7878/4c4f69.png?text=test) ![Example](https://place-hold.it/50/fe640b/4c4f69.png?text=test) | 2.67 | | Sapphire | ![Example](https://place-hold.it/50/209fb5/4c4f69.png?text=test) | 2.54 | | Lavender| ![Example](https://place-hold.it/50/7287fd/4c4f69.png?text=test) | 2.50 | | Green | ![Example](https://place-hold.it/50/40a02b/4c4f69.png?text=test) | 2.38:1 | | Teal | ![Example](https://place-hold.it/50/179299/4c4f69.png?text=test) | 2.13:1 | | Maroon | ![Example](https://place-hold.it/50/e64553/4c4f69.png?text=test) | 2.03:1 | | Blue | ![Example](https://place-hold.it/50/1e66f5/4c4f69.png?text=test) | 1.62:1 | | Mauve, Red (Status Quo) | ![Example](https://place-hold.it/50/8839ef/4c4f69.png?text=test) ![Example](https://place-hold.it/50/d20f39/4c4f69.png?text=test) | 1.47:1 |

On the other hand, this might break contrast ratios for other themes but it took me over 40 minutes to create the table so I'll post this comment anyways.