fix: rewrite install.sh in POSIX shell for portability

catppuccin / kde

🌻 Soothing pastel theme for KDE

MIT License

383 stars 21 forks source link

fix: rewrite install.sh in POSIX shell for portability #46

Closed Stonks3141 closed 10 months ago

Stonks3141 commented 10 months ago

Contrary to popular belief, bash is not universal on Linux systems.

Check $XDG_DATA_HOME
Replace multiline string literals with heredocs
Replace Bash's [[ with the universal [
Use case instead of if-else chains where appropriate
Quote some more variables
Clean up sed scripts
Indicate default choice in yes/no prompts
Replace Bash functions with regular shell functions
Don't sleep for fractional seconds (not all sleeps support fractional seconds)
Use subshells to avoid having to cd .. after cd'ing
Combine some repetitive code

Sourcastic commented 10 months ago

Hi, really appreciate the PR making sure it's POSIX compliant. Most of the people working on the project write and test the script(s) on bash, so this is nice.

However, unfortunately, in my testing this seems kind of borked. I personally don't have the time to make some of the necessary fixes. If you are willing to make the changes, that'll be great, otherwise we might have to wait for someone to pick this up if that's ok.

Stonks3141 commented 10 months ago

Thanks for taking a look! Could you paste the output? I can't test it easily.

Sourcastic commented 10 months ago

Hi, sorry for the late reply but:

This is what I see when I try to run through the options, there might be more after this but this is where it taps out

install.sh: line 452: syntax error near unexpected token `then'

install.sh: line 452: `if [ "$CONFIRMATION" = "Y" ]] || [ "$CONFIRMATION" = "y" ]; then'

Stonks3141 commented 10 months ago

Whoops, seems like I forgot to delete a bracket. Try it now.

Sourcastic commented 10 months ago

Hi, there are a few more errors after still. Looks like more missing brackets. I think there might be even more after, uh.. might be best to do a quick run through of the script till it executes.

install.sh: line 381: unexpected EOF while looking for matching `]' install.sh: line 487: syntax error: unexpected end of file

Stonks3141 commented 10 months ago

Okay, shellcheck is passing on it now so should be all done.

Sourcastic commented 10 months ago

Yup, it seems to fully work now!! Great work, thank you so much! I'll ask people to test this on the discord as well, and if nothing comes up, we'll get this merged.