search

catppuccin / kde

🌻 Soothing pastel theme for KDE
MIT License
383 stars 21 forks source link

Mention dependency on wget and unzip. #53

Closed breuxi closed 4 months ago

breuxi commented 4 months ago

Greetings,

thank you for creating this beautiful theme and convenient installer! Sadly I had a problem using it, because my machine was missing the unzip package, so the script could not extract some of the contents. By looking at the scripts source, I also saw that wget is used. I know that most linux distros should be shipping these packages by default, but some do not, so in my opinion it would be nice to have it mentioned in the install section of the Readme or have the script check for their presence and exit or output a warning if it fails to find them.

I know that this is probably just a convenience thing, but it could spare somebody the debugging effort and would not be too difficult to implement.

I would also be willing to submit a pr for such behavior if needed! :)

Have a nice day everyone, Breuxi

backwardspy commented 4 months ago

seems like a good idea to me, feel free to submit a PR!

Sourcastic commented 4 months ago

Hey, I've just pushed a fix for this. If I uninstall wget or unzip or a few other commands, it does now exit the script and output an error message.

Tysm for raising the issue.

breuxi commented 4 months ago

Wow, great work! Thank YOU so much for fixing it! Have a nice day everyone! 💜