search

catppuccin / kde

🌻 Soothing pastel theme for KDE
MIT License
437 stars 26 forks source link

Update installer script #55

Closed dinckelman closed 7 months ago

dinckelman commented 7 months ago

Two patches included:

Issues worth noting:

I strongly recommend checking if everything makes sense, before attempting to merge, because I have probably made mistakes somewhere. Several trial runs with different configurations have not shown immediate issues

Sourcastic commented 7 months ago

Hey, thank you so much for this. I'll take a proper look at this tomorrow, as it's quite late.

However, we have uploaded the plasma 6 aurorae themes to the KDE Store now: https://www.pling.com/u/catppuccin/products. If you're interested, we could have it work as it did before.

pluiedev commented 7 months ago

As Plasma 6 is still very new I think it's necessary to preserve Plasma 5 support for now. Perhaps when Plasma 5 is declared EOL then we can remove support for it

Sourcastic commented 7 months ago

I don't think the plan is to necessarily "remove support" per se. Once the porting work is done, I'll make one final Plasma5 release (0.2.5) to point people to (and maybe even add a note in the readme). And then make a 0.2.6 release onwards.

Though, testing @dinckelman's patch, it works just fine on Plasma 5 still.

dinckelman commented 7 months ago

However, we have uploaded the plasma 6 aurorae themes to the KDE Store now: https://www.pling.com/u/catppuccin/products. If you're interested, we could have it work as it did before.

Definitely a possibility. That could just be left as a debug flag, and omitted from the regular process.

As Plasma 6 is still very new I think it's necessary to preserve Plasma 5 support for now. Perhaps when Plasma 5 is declared EOL then we can remove support for it.

Like I've mentioned, I think this should be taken a look at for sure. I was considering adding a check for which version is available, however I believe it's better to leave that up to debate for the original maintainers.

One thought I've had in the meantime is that this could potentially be split twofold. Since the script already installs the entire theme as-is, without the need of kpackagetool, it could just be omitted. I imagine if you're using Pling to get the theme, you won't really be dealing with this to begin with. I suppose that's what the specific definitions in the metadata were helpful for before

Sourcastic commented 7 months ago

Ok so I tested this on plasma 5, the script does work, this still applies though:

None of the themes apply automatically, however all of them apply manually correctly from Global Themes

This wasn't how it worked before, I've been trying to see why for a while now, but it's confusing. For some reason, the kpackage that forms is the splash theme? So if you installed Mocha + Muave, it makes Catppuccin-Mocha-Muave-splash which obviously makes the lookandfeeltool command fail. I'll try to fix this tomorrow, otherwise it does work.

Like I've mentioned, I think this should be taken a look at for sure. I was considering adding a check for which version is available, however I believe it's better to leave that up to debate for the original maintainers.

I was thinking of doing something like this as well, but somehow it does work on plasma 5.

One thought I've had in the meantime is that this could potentially be split twofold. Since the script already installs the entire theme as-is, without the need of kpackagetool, it could just be omitted. I imagine if you're using Pling to get the theme, you won't really be dealing with this to begin with. I suppose that's what the specific definitions in the metadata were helpful for before

Yup, this was how it originally worked. It could make sense to revert it to that behaviour. For now, it might be better to get the kde6 port out as soon as possible if it works and then try to make those changes.

Definitely a possibility. That could just be left as a debug flag, and omitted from the regular process.

Also, yes. Either way would work on both plasma 6 and 5 as well since it includes both metadata.desktop and metadata.json.

Sourcastic commented 7 months ago

Hey, so I've tried to fix the whole theme-not-applying issue, but I couldn't get it to work. It works just fine on plasma 5 with kpackagetool5, but they seemed to have changed something in plasma 6 that isn't well documented.

Just added a quick workaround that removes the reliance on kpackagetool6, would appreciate it if someone could test it out real quick, and then we could get this merged.

P.S: Sorry for the double commit.

dinckelman commented 7 months ago

Appears to be working properly for me. It actually even applies the theme too now, on Plasma 6

Sourcastic commented 7 months ago

Appears to be working properly for me. It actually even applies the theme too now, on Plasma 6

Oh, does it? It didn't for me. I'll ask a couple of people on discord to see how it behaves.

NullCub3 commented 7 months ago

Chiming in here, the script works great for me, everything seems to apply correctly except for the splash screen for some reason. The theme is still in the settings but it doesn't appear to get switched to from my testing.

Sourcastic commented 7 months ago

Ok so asking around, that seems to line up with most people's experience. The splash screen isn't ported (That requires some QML knowledge I suppose) and the lightly plasma theme doesn't install. It does, however, apply.

I think some of the changes then would be to port the splash theme and we should maybe remove lightly and just shift to default breeze? Thoughts?

pluiedev commented 7 months ago

Personally I think Plasma 6 Breeze is perfectly aesthetically pleasing enough for me. Plus, I think it is a tad weird that Catppuccin, which is supposed to just be a color scheme system, bundles an alternate window decoration set and such anyway.

Sourcastic commented 7 months ago

Personally I think Plasma 6 Breeze is perfectly aesthetically pleasing enough for me. Plus, I think it is a tad weird that Catppuccin, which is supposed to just be a color scheme system, bundles an alternate window decoration set and such anyway.

Very fair, yeah. I think it's something that's left from when another person was the main maintainer. I'll try to make it breeze by default then.

Sourcastic commented 7 months ago

I'll stop hijacking this PR then, thank you so much for your help @dinckelman, I'll add you to the contributor's list as well!! :heart:

Edit: Due to overall org policy, the contributor's list has been deprecated in favour of what GitHub just has automatically. Still, tysm for your help.