search

catppuccin / kde

🌻 Soothing pastel theme for KDE
MIT License
383 stars 21 forks source link

Fix: Uncomment splash screen metadata sed #64

Closed xarblu closed 3 months ago

xarblu commented 3 months ago

Currently in Plasma 6 the splash screen shows up in settings but due to missing metadata:

  1. doesn't have a name
  2. isn't selectable or previewable

Considering the things are already fully there and just commented out I'm guessing someone just forgot to uncomment them for 0.2.6.

Sourcastic commented 3 months ago

Currently in Plasma 6 the splash screen shows up in settings but due to missing metadata:

  1. doesn't have a name
    1. isn't selectable or previewable

Hmm, though weirdly I can't seem to recreate this. The splash screen shows up normally for me. The intention here is that it'll be installed as a part of the global theme instead of separately with its own metadata to prevent it appearing in the global theme settings page.

Image attached for how it seems to be appearing properly:

image

That said, this will probably be reworked eventually down the line when I have more free times and those lines would be included.

xarblu commented 3 months ago

The intention here is that it'll be installed as a part of the global theme

Oh yea true, now I'm seeing that change. I must've missed that when porting my Gentoo package from 0.2.5 to 0.2.6. Afaik 0.2.5 used to have the splash screens separate so I was confused why it didn't have any metadata in 0.2.6.

I'll close this then. Thanks anyways!