search

catppuccin / logseq

🦫 Soothing pastel theme for Logseq
MIT License
140 stars 3 forks source link

Add styles for the new whiteboard feature #12

Closed griimick closed 10 months ago

griimick commented 1 year ago

This was requested in the official Logseq discord. A few new CSS variables and overrides were used in the feature which stand out of the theme.

LateNightIceCream commented 1 year ago

@griimick Have you worked on this already? Otherwise, I would give it a shot since I'd use it for my version as well :)

griimick commented 1 year ago

@griimick Have you worked on this already? Otherwise, I would give it a shot since I'd use it for my version as well :)

I have't started on it. There were a few new variables and hard coded colors introduced in whiteboard feature.

LateNightIceCream commented 1 year ago

Ok, then I will check it out. I will try to figure out the vars and make a rough draft

LateNightIceCream commented 1 year ago

So far so good. I tried to adhere to the default theme style. There are some tricky things to consider. E.g., the text and line colors share a variable.

Also, for the shapes, like the rectangles in the screenshot, there are two options:

  1. shade the text color and keep the shape fill color default (e.g. --ctp-red) - this is like the default theme
  2. shade the fill and keep the text color default

I think option 1 it is actually a little hard to read but it is the same for the default theme. But I just noticed that the font size in the screenshots is a little small to judge that.

Another question is what exact color the shades should be. In the screenshots, I used a mix of --ctp-colorX with 60% --ctp-base for the fill or the text, respectively.

Lmk what you think!

Current: logseq-ctp-whiteboard-3

Option 1: logseq-ctp-whiteboard-1

Option 2: logseq-ctp-whiteboard-2

griimick commented 1 year ago

I would prefer option 1 as it's close to what default logseq theme.

The readability can be improved by the users themselves as there's an option to choose a custom color. We might have to see how that works with this theme as well.

Can you open a PR for this as well? I would like to play around with it a bit.

Thanks for working on this :) I have been sleeping on it since I migrated to Obsidian.

LateNightIceCream commented 1 year ago

I agree! And I will open the PR tomorrow. I hope you won't mind the messiness ^^