search

catppuccin / logseq

🦫 Soothing pastel theme for Logseq
MIT License
154 stars 3 forks source link

Simple fix for code mirror light theme #14

Closed LateNightIceCream closed 1 year ago

LateNightIceCream commented 1 year ago

Regarding Issue https://github.com/catppuccin/logseq/issues/13

Just copying the dark theme configuration in _codemirror.scss for the light theme (catppuccin latte). You can probably simplify the sass to remove the repetition... but it works this way!

Here is the result:

Before (default solarized look while catppuccin latte is selected as logseq theme): logseq-ctp-code-block

After: image

griimick commented 1 year ago

Thanks for working on this, I would like refactor this change to existing _codemirror.scss.

griimick commented 1 year ago

@LateNightIceCream I am unable to push commit to this PR even as a maintainer. Not sure what's going wrong. You can either give me write perms to your fork or you can make these changes yourself in this PR. My suggestions are in this gist: https://gist.github.com/griimick/85ffe6197d874d78429569b7abe0ce65

Please checkout if it seems to working fine on your end as well. Upon your commit and confirmation, I will merge the changes.

LateNightIceCream commented 1 year ago

It's working as expected. I updated the branch