search

catppuccin / logseq

🦫 Soothing pastel theme for Logseq
MIT License
154 stars 3 forks source link

Links are barely visible on highlight #19

Closed WPum closed 10 months ago

WPum commented 11 months ago

image

griimick commented 11 months ago

Thanks for reporting this. Will include fix for this in holiday update as a lot of other elements have broken after recent logseq update.

mwidmann commented 10 months ago

May I just jump in in this. Using catppuccin-latte in light mode text selection color is berely legible as well.

image

So it seems the issue is related to both the dark and the light theme. The problem seems to be that the background-color of the selection comes from the logseq theme itself, while the color comes from the ctp-latte.css.

The easiest fix would be to not touch the ::selection at all, it seems or change both the color and background-color to something that has enoug contrast to be legible.

For the time being, I added the following snippet to my custom.css

::selection {
    color: inherit;
}
griimick commented 10 months ago

Thanks @mwidmann for the inputs! If you would like to contribute you can create a PR, I would be happy to add this. Otherwise, I have a few more fixes along with this on the way, just haven't got the time to make a release yet.

mwidmann commented 10 months ago

I created a pull request https://github.com/catppuccin/logseq/pull/21