catppuccin / logseq

🦫 Soothing pastel theme for Logseq
MIT License
154 stars 4 forks source link

Regression issues from v0.5 #28

Closed griimick closed 8 months ago

griimick commented 8 months ago

Issues reported over Logseq discord and DM,

Chais commented 8 months ago

I'd go so far as to say the theme is barely applied at all This is the default theme:
Screenshot from 24-03-05_16:22:27

And this is with Catppuccin-Mocha applied:
Screenshot from 24-03-05_16:22:35

I thought I saw a slight gradient after applying it, but now I can't detect it. Also I noticed the config editor is nearly unusable, as it doesn't display a cursor nor highlight the current line or selected text, making navigation and editing rather challenging.

griimick commented 8 months ago

@Chais Thanks for reporting. Can you share what version of Logseq and Catppuccin theme are you using?

If you are using the latest Logseq v0.10.7, please make sure to cancel the accent selection as this theme currently does not support any of the accents (not even the default Logseq accent). This change is temporary and I plan to at least support the default Logseq accent in a future release.

Screenshot 2024-03-05 at 9 01 31 PM
Chais commented 8 months ago

I did not. Running on NixOs 23.11, so I had 0.10.6, which didn't offer that option. Pulling 0.10.7 from unstable fixed my issues. Sorry for the noise.

griimick commented 8 months ago

I did not. Running on NixOs 23.11, so I had 0.10.6, which didn't offer that option. Pulling 0.10.7 from unstable fixed my issues. Sorry for the noise.

No worries! Thanks again for reporting, I will test with 0.10.6 and include a fix if it has broken for an older version which shouldn't have been in the first place!

sofiedotcafe commented 8 months ago

@Chais @griimick Is this issue related? After updating to the newer version (at least the theme loads now), the whiteboard looks kinda bad? image

sofiedotcafe commented 8 months ago

This seems to happen on other themes also, weird?

Chais commented 8 months ago

You'll have to be more specific.
New version of the theme?
Tested on which version of logseq?

sofiedotcafe commented 8 months ago

You'll have to be more specific. New version of the theme? Tested on which version of Logseq?

Oh sorry,

Logseq version: 0.10.7 Theme version: v0.5

Can you @Chais reproduce?

Chais commented 8 months ago

I'm not sure what exactly you're referring to. But I never used whiteboards all that much, so I'm not very familiar with their look.
Screenshot from 24-03-05_19:44:11

griimick commented 8 months ago

Logseq version: 0.10.7 Theme version: v0.5

@jh-devv Thanks for the report!

I can repro this. As Logseq is undergoing its design system changes, lots of element styles are breaking and will keep breaking in future releases. I have added this to the list above for the next release.

image image
sofiedotcafe commented 8 months ago

Logseq version: 0.10.7 Theme version: v0.5

@jh-devv Thanks for the report!

I can repro this. As Logseq is undergoing its design system changes, lots of element styles are breaking and will keep breaking in future releases. I have added this to the list above for the next release. image image

Thanks! :)

rich-williamson commented 8 months ago

+1 to this, I'm having the same issue since updating to 0.5. The theme is basically not working at all on any flavour. Logse 0.10.6 on Ubuntu if that helps.

griimick commented 8 months ago

+1 to this, I'm having the same issue since updating to 0.5. The theme is basically not working at all on any flavour. Logse 0.10.6 on Ubuntu if that helps.

Thanks for the report! I am working on a fix for this to support 0.10.6 users.

You can also upgrade to 0.10.7 as it introduces an option to cancel accent selection which works with v0.5 of this theme.