PDF text hightlighting color

liperium commented 2 days ago

Is there an existing issue outlining your problem?

[X] I have searched the existing issues and they do not solve my problem.

Describe your problem.

Opening a pdf file using the Mocha theme, everything is fine. But when I get to highlight text, the "hidden" text, made to be selected, when selected, becomes black. Thus macking this very bizzare look.

Usually, the text color should remain transparent. I have css knowledge, but have no clue how to get the class/ids of electron apps! Happy to help if needed.

Attach screenshots.

Issue.

( Opening it in another window, removes theming ) This is what it should look like.

What Logseq version do you see the issue on?

0.10.9

What theme version do you see the issue on?

0.6.4

Any additional comments?

No response

liperium commented 2 days ago

I have found a fix to this issue, that seems to work.

.pdfViewer > .page > .textLayer > span::selection {
  color: transparent;
}

liperium commented 2 days ago

More over, maybe this is not a bug more of a feature. Cause as I can see pdf's are only supported on the desktop. To make highlighting and the popup menu conform to the theme. I have added theses two other rules :

.extensions__pdf-hls-ctx-menu {
  background: @surface0;
  color: @text;
}
.extensions__pdf-hls-ctx-menu>li.item:hover {
    background-color: @surface1;
}

Making this popup menu styled.

catppuccin / logseq