catppuccin / nix

❄️ Soothing pastel theme for Nix
https://nix.catppuccin.com/
MIT License
316 stars 45 forks source link

Document modules that need Allow From Derivation #172

Open vdbe opened 2 months ago

vdbe commented 2 months ago

An extra readme segment that specifies which modules require Allow From Derivation or/and an option to exclude those modules from the global enable option.

vdbe commented 2 months ago

Willing to implement it myself, just let me know.

getchoo commented 2 months ago

documenting what modules contain it would be nice. feel free to PR it to our FAQ

regarding excluding them from the global enable option: i can see why this might be a requested feature, but i feel would overcomplicate how we actually implement catppuccin.enable for what's a pretty niche feature. giving a neat list of modules should be good enough for most i'd imagine

vdbe commented 2 months ago

For the option my idea was to have 1 place (2 nixos and home manager) where you use mkOverride with priority over MkOptionDefault.

This way you don't need to touch mkCatppuccinOpt and can possibly generate the description for documentation instead of a Readme/FAQ segment.

Don't know yet how you would test it so that it is not a best effort option.

Would this implementation be overcomplicated?

vdbe commented 3 weeks ago

All the IFD's at the time of writing

    # IFD's
    programs = {
      cava.catppuccin.enable = false;
      foot.catppuccin.enable = false;
      gh-dash.catppuccin.enable = false;
      imv.catppuccin.enable = false;
      kitty.catppuccin.enable = false; # IFD is inside HM
      lazygit.catppuccin.enable = false;
      mpv.catppuccin.enable = false;
      swaylock.catppuccin.enable = false;
      tofi.catppuccin.enable = false;
      zathura.catppuccin.enable = false;
    };
    services = {
      dunst.catppuccin.enable = false;
      mako.catppuccin.enable = false;
    };
mightyiam commented 1 week ago

From my experience, nix flake show can fail due to these. Perhaps that could impact how niche we perceive this issue to be.