search

catppuccin / nix

❄️ Soothing pastel theme for Nix
https://nix.catppuccin.com/
MIT License
302 stars 46 forks source link

fix(nixos/sddm): use the kde sddm package #230

Closed isabelroses closed 1 week ago

isabelroses commented 3 weeks ago

This resolves the error where the theme doesn't work if plasma6 isn't enabled. by default the packge is qt5 sddm, but catppuccin/sddm uses qt6.

isabelroses commented 3 weeks ago

closes https://github.com/catppuccin/nix/issues/229

isabelroses commented 2 weeks ago

I think the easiest thing would be to check what package is being used since it's either the qt5 one or the kde package.

isabelroses commented 2 weeks ago

or perhaps lib.mkDefault would be better so we don't get clashes with users that apply the plasma 6 desktop.

getchoo commented 2 weeks ago

I think the easiest thing would be to check what package is being used since it's either the qt5 one or the kde package.

that's what i meant with a conditional assertion. it wouldn't account for overriden packages ofc, but if someone really knows what they're doing they can disable it with an option

or perhaps lib.mkDefault would be better

i don't think it would as users could easily set the qt5 package as normal with no warning. assertions on the other hand provide a built in explanation of why we need to use the qt6 version when this happens

so we don't get clashes with users that apply the plasma 6 desktop

why would this happen?

isabelroses commented 2 weeks ago

why would this happen?

The duplicate package deceleration I mean.