catppuccin / nvim

🍨 Soothing pastel theme for (Neo)vim
MIT License
5.57k stars 255 forks source link

Mini Statusline doesn't seem to match intended Catppuccin colors #451

Closed Diablo-D3 closed 1 year ago

Diablo-D3 commented 1 year ago

Description

Currently, the colors in Mini Statusline are a shade too dark

Neovim version

NVIM v0.9.0-dev-1258+ge789d6529
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

Terminal and multiplexer

alacritty with tmux

Catppuccin version / branch / rev

main

Steps to reproduce

Not configuration dependent, only requires Mini Statusline.

Changing https://github.com/catppuccin/nvim/blob/f078aa49bef4cb9e7b86f07b607c6e98c95b9fb5/lua/catppuccin/groups/integrations/mini.lua#L34-L35 to match

            MiniStatuslineFilename = { fg = C.text, bg = C.surface0 },
            MiniStatuslineInactive = { fg = C.blue, bg = C.surface0 },

Seems to bring it further in line with the treatment other statusline plugins get in Catppuccin according to the README's screenshots.

Expected behavior

image

Actual behavior

image

Repro

No repro included, see screenshots and included suggested fix.
nekowinston commented 1 year ago

Which statuslines are brighter than base? Other programs and integrations do use mantle as the main background color:

https://github.com/catppuccin/nvim/blob/5e31d3ce29aa17b7a047b1a0e6b9ce9d6702c511/lua/lualine/themes/catppuccin.lua#L5 https://github.com/catppuccin/nvim/blob/5e31d3ce29aa17b7a047b1a0e6b9ce9d6702c511/lua/catppuccin/groups/integrations/bufferline.lua#L18 https://github.com/catppuccin/nvim/blob/5e31d3ce29aa17b7a047b1a0e6b9ce9d6702c511/lua/catppuccin/groups/integrations/navic.lua#L3-L5

Feline is the odd one out, IMO that one is in the wrong: https://github.com/catppuccin/nvim/blob/5e31d3ce29aa17b7a047b1a0e6b9ce9d6702c511/lua/catppuccin/groups/integrations/feline.lua#L27-L40

Diablo-D3 commented 1 year ago

The screenshot from the README seems to indicate the darkest color on the statusbar (ex: the ubiquitous middle segment that displays the filename) should be one shade brighter than the normal background.

nekowinston commented 1 year ago

That screenshot shows Feline, which is the current outlier. Other Catppuccin ports, such as VSCode, JetBrains, etc. use mantle.