catppuccin / nvim

🍨 Soothing pastel theme for (Neo)vim
MIT License
5.34k stars 237 forks source link

Semantic Highlighting - basedpyright #681

Closed karimlevallois closed 5 months ago

karimlevallois commented 5 months ago

Is there an existing issue for this?

What is your concern?

With the release of the new pyright fork basedpyright, semantic highlighting has now been enabled within Python. However, it looks like something might have to be updated in catppuccin as enabling semantic highlighting seems to change functions from peach to blue.

Please see my comments / screenshots on the below issue:-

https://github.com/DetachHead/basedpyright/issues/176

backwardspy commented 5 months ago

judging from your comments there i assume you're referring to the neovim port. please raise an issue over at catppuccin/nvim. thanks!

backwardspy commented 5 months ago

just been reminded issues can be transferred :)

sgoudham commented 5 months ago

Not read the full context of the issue but its worth saying that according to the style-guide, methods/functions should be blue.

afaik, Neovim still needs to get updated according to the revamped style guide so that might be part of the reason for the colour change?

karimlevallois commented 5 months ago

Ah OK, so have methods / functions have now changed from peach to blue? There was just too much blue going on for my liking, hard to spot the differences.

Before:-

IMG_1382

Afrer:-

IMG_1381
nullchilly commented 5 months ago

You can try Overwriting highlight groups to adjust to your liking

require("catppuccin").setup {
  custom_highlights = function(C)
    return {
      ["@lsp.typemod.function.builtin"] = { fg = C.peach },
    }
  end
}
karimlevallois commented 5 months ago

@nullchilly Out of curiosity, why are my functions peach if they have been updated to blue under the below?

https://github.com/catppuccin/nvim/blob/main/lua/catppuccin/groups/syntax.lua

I am not currently overriding any colours and this is the same on both LazyVim and Lunarvim - peach from functions.