catppuccin / nvim

🍨 Soothing pastel theme for (Neo)vim
MIT License
5.62k stars 255 forks source link

add support for fzf-lua #739

Closed zspher closed 3 months ago

zspher commented 3 months ago

Is your feature request related to a problem? Please describe. Hi, this is a nice theme. I would like to request for support for fzf-lua

Describe the solution you'd like Theme for fzf-lua via integration

Additional context highlight groups for fzf-lua: https://github.com/ibhagwan/fzf-lua?tab=readme-ov-file#highlights

zspher commented 3 months ago

currently using the ff. colors

FzfLuaBorder = { link = "FloatBorder" },
FzfLuaTitle = { link = "FloatBorder" },

FzfLuaHeaderBind = { fg = c.yellow },
FzfLuaBufNr = { fg = c.yellow },
FzfLuaTabMarker = { fg = c.yellow },
FzfLuaHeaderText = { fg = c.peach },
FzfLuaBufFlagCur = { fg = c.peach },
FzfLuaLiveSym = { fg = c.peach },

FzfLuaPathColNr = { fg = c.blue },
FzfLuaBufFlagAlt = { fg = c.blue },
FzfLuaTabTitle = { fg = c.sky },

FzfLuaPathLineNr = { fg = c.green },
FzfLuaBufName = { fg = c.mauve },

from

BlanchedAlmond -> yellow
Brown1 -> peach
CadetBlue1 -> blue
LightGreen -> green
LightMagenta -> mauve
LightSkyBlue1 -> sky
vollowx commented 3 months ago

Seems to be a nice idea! I'll make this ASAP when I get some time!

db757 commented 3 months ago

This is what I currently use which complies with the fzf catppuccin theme and some personal preference changes:

'FzfLuaBorder', { link = "FloatBorder" }
'FzfLuaTitle', { link = "FloatBorder" }
'FzfLuaHeaderText', { foreground = C.mauve } -- Personal preference
'FzfLuaHeaderBind', { foreground = C.rosewater } -- Personal preference
...
fzf_colors = {
    ["bg"] = '-1', -- Transparent background, originally base
    ["fg"] = C.text,
    ["bg+"] = C.ui_selection, -- Custom color, originally surface0
    ["fg+"] = C.text,
    ["hl"] = C.red,
    ["hl+"] = C.red,
    ["spinner"] = C.rosewater,
    ["header"] = C.mauve, -- Personal preference, originally red
    ["info"] = C.mauve,
    ["pointer"] = C.rosewater,
    ["marker"] = C.rosewater,
    ["prompt"] = C.mauve,
    ["gutter"] = '-1', -- Transparent background
},
vollowx commented 3 months ago

At this point of working on the fzf integration, I'm not sure whether should I

  1. Copy the highlights in catppuccin/fzf into catppuccin/nvim besides the fzf_lua ones (requires fzf_colors = true in its setup function)
  2. Just highlight the fzf_lua ones

The 1st way causes duplication and might be out-dated when catppuccin/fzf updates, and the 2nd way requires users to finish the fzf highlights.

zspher commented 3 months ago

i think the 2nd option should be better as it allows of more consistency and less maintenance. The fzf highlights should be the user's responsibility, either setting it in the fzf_lua plugin or via $FZF_DEFAULT_OPTS env.

vollowx commented 3 months ago

Will write the PR soon :heart: