catppuccin / obsidian

💎 Soothing pastel theme for Obsidian
MIT License
340 stars 15 forks source link

[Bug] Search suggestion note is not readable for hovered items #26

Closed onnyyonn closed 1 year ago

onnyyonn commented 1 year ago

The search suggestion title changes color for a hovered item, but the search suggestion notes don't, which may make theme unreadable. The following screenshots illustrate the issue:

Current Behavior: Screenshot_20221025_031739

Desired Behavior: Screenshot_20221025_031820

Possible Fix:

.suggestion-item.is-selected .suggestion-note{
  color: var(--text-on-accent);
}
mbeckrich commented 1 year ago

Thanks, will fix in the morning! On Oct 25, 2022, at 1:27 AM, Anamitra Saha @.***> wrote: The search suggestion title changes color for a hovered item, but the search suggestion notes don't, which may make theme unreadable. The following screenshots illustrate the issue: Current Behavior:

Desired Behavior:

Possible Fix: .suggestion-item.is-selected .suggestion-note{ color: var(--text-on-accent); }

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

mbeckrich commented 1 year ago

Okay, should be fixed in https://github.com/catppuccin/obsidian/commit/2c3a0bf6eb5efcc701a7c929d214e61890a224d8. I think the issue was due to the Better Command Palette plugin styling -- I could not replicate the problem without installing and using the plugin. I have also gone ahead and adjusted some of the css the plugin uses so that it has similar margins/padding to the rest of the theme. If you want to make any changes yourself, use the .better-command-palette selector. Let me know if you run into further issues!