Search results readability

[ArtemisFowl-san]

Hey, there

I really adore the theme you have given us.

One thing I do find myself struggling with is readability of search results when using the theme in dark mode, as seen in the screenshot.

Is there a way to adjust this in style settings or is there another fix for this. I checked the closed issues and could not find anything on this.

EDIT: Another example are the folders in the plug in the another quick switcher plug in. I understand that you cannot have support for all plug ins just thought I would mention it as another example

[mbeckrich]

Thanks! Getting the search result highlights nailed down has been tricky -- lots of sneaky CSS for them. Can you give me a little more context for the first screenshot? Is it from a plugin as well and are you using the full palette or one of the style settings specific ones? This is what my search results look like:

I will install the plugin in the second pic and get that fixed.

Edit: I have made some changes to the CSS for the plugin, so the poor contrast in your second pic shouldn't happen now (or at least not where I found it happening lol). Let me know if there are other spots I missed. As far as the search results, any additional context you can give (bigger screenshot, name of css element, etc.) would be helpful because I am not sure I recognize the part of the UI in your pic, sorry!

[ArtemisFowl-san]

Hey, thanks for the quick fix for the folder search results, they look perfect now 👍

As for the first screenshot, it is the same anotherquickswitcher plug in and it is the same search bar, only that it already previews some of the search results for headers or keywords or inside the file

This image is the same, so the folder indicator on the right is perfect now as is the file name, only the in-file search results are still very hard to read.

I hope this helps. If I can do anything else to help just let me know.

[mbeckrich]

Cool, I think I may have been able to correct it using the grep search feature to test. This should reflect the native search results of the app now. Can you let me know if I am still missing any of the plugin's css? Thanks!

[ArtemisFowl-san]

Looks perfect now, thanks a lot !

I don't want to bother you too much with plug in compatbility, because I imagine it is an endless task, but would you mind also looking into the omnisearch plug in search results (see screenshot).

Feel free to skip this if it's too much just thought that I would ask :)

[mbeckrich]

Glad it’s looking better! I’ll take a look at the other plugin tonight and give you an update when I get it compatible with the theme. :)

On Jan 14, 2023, at 3:00 AM, ArtemisFowl-san @.***> wrote:

Looks perfect now, thanks a lot ! I don't want to bother you too much with plug in compatbility, because I imagine it is an endless task, but would you mind also looking into the omnisearch plug in search results (see screenshot). Feel free to skip this if it's too much just thought that I would ask :)— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

[mbeckrich]

Okie doke, let me know how that looks now. Don't feel bad about asking for plugin additions -- happy to do it when I have time. You're also welcome to submit PRs for review if you're famliar with CSS (or want to learn!) and want to contribute. :)

[ArtemisFowl-san]

thanks, and yes once I am done with exams for this semester I was thinking about diving a bit deepter into CSS, so will definitely come back to this then :)

[mbeckrich]

Great! I updated the readme a couple days ago with some additional info about contributing and there's a footnote that gives an example of how to build the app scss with sass if you haven't used it before. I'll close this for now but let me know if there's anything else I can do to help. Good luck with exams!