search

catppuccin / obsidian

💎 Soothing pastel theme for Obsidian
MIT License
401 stars 15 forks source link

Add proper italic style. #46

Closed hiimsergey closed 1 year ago

hiimsergey commented 1 year ago

Hello,

At first I would like to thank for the effort put into this gorgeous theme as well as the excellent font choice.

However, I found that italic text looks kind off odd. Comparing with the official font website, Vollkorn, the current implementation lacks its style.

Italic text on the website: 20230807_15h26m41s_grim

Italic text in my vault: 20230807_15h36m26s_grim

Basically, it inherits the same serif style from regular text and slants it.

I'm not sure if it's intentional or not and if it's possible to change it.

However, thank you in advance.

mbeckrich commented 1 year ago

Thanks for catching this! I will look into it and get you a fix later today. On Aug 7, 2023, at 7:39 AM, serg @.***> wrote: Reopened #46.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

hiimsergey commented 1 year ago

(Accidentally closed the issue, oops.)

I found this base64 encoder at https://amio.github.io/embedded-google-fonts and encoded Vollkorn Italic 400 from Google Fonts and just pasted the output and the end of theme.css. It solved the issue for me.

mbeckrich commented 1 year ago

Awesome, I’ll plan on adding that and crediting you with the fix when I get to the computer in a bit. 😎 On Aug 7, 2023, at 8:35 AM, serg @.***> wrote: (Accidentally closed the issue, oops.) I found this base64 encoder at https://amio.github.io/embedded-google-fonts and encoded Vollkorn Italic 400 from Google Fonts and just pasted the output and the end of theme.css. It solved the issue for me.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

mbeckrich commented 1 year ago

This should be updated as of https://github.com/catppuccin/obsidian/commit/7e853eeb5b4d7022e5497080e47a3489d9ee4b5a. Let me know if you run into further issues. Thanks again for catching this and providing the quick solution.