catppuccin / obsidian

💎 Soothing pastel theme for Obsidian
MIT License
340 stars 15 forks source link

Files aren't highlighted on selection using buttons #60

Closed PhungThanhTu closed 1 month ago

PhungThanhTu commented 1 month ago

I came across a weird situation where the folders are highlighted with a gray bordered box when highlighted, but files aren't highlighted.

Context (Catppuccin)

Folders:

image

Files:

It just disappeared.

image

Context (Default theme)

It works normally on default themes.

Folders

image

Files

image

Context (Other themes such as Dracula)

It also works on other themes (I picked Dracula Official).

Folders

image

Files

image

mbeckrich commented 1 month ago

I’ll try to take a look at this today and get a fix out. Appreciate the details!On May 19, 2024, at 6:40 AM, TuPT @.***> wrote: I came across a weird situation where the folders are highlighted with a gray bordered box when highlighted, but files aren't highlighted. Context (Catppuccin) Folders: image.png (view on web) Files: It just disappeared. image.png (view on web) Context (Default theme) It works normally on default themes. Folders image.png (view on web) Files image.png (view on web) Context (Other themes such as Dracula) It also works on other themes (I picked Dracula Official). Folders image.png (view on web) Files image.png (view on web)

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

mbeckrich commented 1 month ago

I'm having some difficulty replicating this. I want to make sure we're using the term 'highlighting' the same way. When I hover my cursor over a file or folder name, I see this:

image

When I hover over an 'active' (i.e., clicked on file), I see this (it changes from pink, the active color, to blue):

Screenshot 2024-05-19 at 10 01 11 AM

Are you using the term 'highlighting' to describe the same activity?

I notice that it looks like you have changed the color of file names in the theme. Have you adjusted any css through a snippet (or plugin) that might interact with the theme in a way that could cause this? It looks like the snippet is on in the sample from the default theme and off in Dracula (or Dracula supersedes/ignores the snippet), but I wonder if something is going on there? Happy to keep looking into this, just want to make sure I understand where the issue is coming from. :) One possibility is that if you have turned off the hover color on file/folder names, there is css either in or missing from your snippet or Catppuccin that causes the grey border to exist in one case but not the other.

PhungThanhTu commented 1 month ago

@mbeckrich I tried by disabling all other plugins, including "style setting" which is used to change to the "Frappe" flavor, the issue still persists. And the highlight border box is appeared when we traverse through the files using arrow buttons. I made a comparison here for mouse hover (the light colored) and button traverse (the border box). image

That border box won't appear whenever I traverse through files, which makes it difficult to get to the desired file using keyboard.

mbeckrich commented 1 month ago

Thanks! I was able to better understand what was wrong now. I have pushed a fix in https://github.com/catppuccin/obsidian/commit/8f8c8bb9b19bcbeb2667a76b5417fc52170ae027. Reopen this issue and let me know if you run into further issues -- hopefully I didn't break anything. :) I don't use the arrow keys in Obsidian, so I might have missed something, but this fix seems to work for both light and dark mode.