catppuccin / obsidian

💎 Soothing pastel theme for Obsidian
MIT License
340 stars 15 forks source link

Fix colors on Omnisearch's search results #62

Closed GabeVilela closed 1 month ago

GabeVilela commented 1 month ago

Fixes the following problems:

  1. Text colour of the file extension, counter & path, on the current selected search result
  2. Background colour of the highlighted text, on non-selected results

Previews

Before After
image image
image image
mbeckrich commented 1 month ago

Thank you! Will review soon. On May 25, 2024, at 9:34 AM, Gabriel Vilela @.***> wrote:Fixes the following problems:

Text colour of the file extension, counter & path, on the current selected search result Background colour of the highlighted text, on non-selected results

Previews

Before After

image.png (view on web) image.png (view on web)

image.png (view on web) image.png (view on web)

You can view, comment on, or merge this pull request online at:   https://github.com/catppuccin/obsidian/pull/62

Commit Summary

b0df709 Fix omnisearch highlight bg colors on non-selected results b09c7e4 Fix omnisearch active result secondary text's color

File Changes (1 file)

M
scss/vendors/_plugins.scss
(13)

Patch Links:

https://github.com/catppuccin/obsidian/pull/62.patch https://github.com/catppuccin/obsidian/pull/62.diff

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

mbeckrich commented 1 month ago

Thank you -- I've tested locally with the plugin and it looks good! Great first contribution. <3 In the future, if you're feeling brave, you can run sass scss/main.scss theme.css from the project directory to add your changes to the theme.css file (which is what is downloaded for theme users) and update the version in the manifest.json file (in this case, it would go from 0.4.20 to 0.4.21). I will handle that on my end now.

edit: I've also added you to the readme :)

GabeVilela commented 4 weeks ago

Right. Will do next time.