search

catppuccin / palette

🎨 Soothing pastel theme to use within your projects!
https://www.npmjs.com/package/@catppuccin/palette
MIT License
459 stars 36 forks source link

feat: add emoji for each flavor #81

Closed uncenter closed 6 months ago

uncenter commented 6 months ago

Closes #80.

uncenter commented 6 months ago

Thanks for the PR.

I like how the PR looks but I also had some other thoughts on whether we should also include more data including the codepoints and the short name? I don't know enough about emoji rendering and how much the other fields matter but figure it could be nice?

Maybe something like:

"emoji": {
  "rendered": "🌻",
  "codepoint": "U+1F33B",
  "cldr_short_name": "sunflower"
}

Maybe I'm wayyy overthinking it but figured I'd comment it anyways, curious what you think cc: @catppuccin/staff

Ref: unicode.org/emoji/charts/emoji-list.html

Hmm IMO this isn't needed. As per your original issue, {{ flavor.emoji }} is nicer/easier to use than {{ flavor.emoji.rendered }}. Also I don't see an immediate usecase for the additional properties, and if a usecase does come up it is pretty easy to use a library or built in functions (e.g. codePointAt() in JS) to find that information out.

uncenter commented 6 months ago

I believe you should run deno task generate as part of the PR since the CI only runs deno task build, unless you already have 😄

I did but iirc there weren't any changes?

EDIT: Yeah no changes after running both commands.