search

catppuccin / spicetify

🎧 Soothing pastel theme for Spotify
MIT License
469 stars 27 forks source link

refactor(all): move to sass & javascript oriented accent picking #48

Closed ohitstom closed 1 year ago

ohitstom commented 1 year ago

resolves #47

This will affect how users contribute heavily, whilst 100% a positive since sass/scss improves the workflow a tonne and allows cleaner code thats easier to audit, it can put a barrier in place for lower level users to make PRs.

However i believe this PR will have a positive impact overall in people wanting to contribute since (no offense) but you can actually read how it works without jumping back and forward between 50 files 🦖

side note: wow that react is fast, its literally instantaneous....

ghostx31 commented 1 year ago

However i believe this PR will have a positive impact overall in people wanting to contribute since (no offense) but you can actually read how it works without jumping back and forward between 50 files 🦖

Completely agreed (I am at fault too there, tbh haha) We'll have someone test this out in a bit, especially on Windows and once its in the clear, we'll get this merged. Thanks for the PR!