search

catppuccin / spicetify

🎧 Soothing pastel theme for Spotify
MIT License
469 stars 27 forks source link

feat/fix: add missing sapphire accent #53

Closed anuragxone closed 1 year ago

anuragxone commented 1 year ago

i tried to add missing sapphire accent which was missing before, can any maintainer guide me here, i'm kinda new to this stuff, @ohitstom ?

ohitstom commented 1 year ago

looks fine to me, not tested it though. Since when was sapphire a part of the palette though?

anuragxone commented 1 year ago

looks fine to me, not tested it though. Since when was sapphire a part of the palette though?

i kinda don't know when, but i was just applying the theme system wide, and discovered that sapphire was missing, if you approve this change can you put hacktoberfest-accepted label on this, it'll help me a lot until it get merged

ohitstom commented 1 year ago

looks fine to me, not tested it though. Since when was sapphire a part of the palette though?

i kinda don't know when, but i was just applying the theme system wide, and discovered that sapphire was missing, if you approve this change can you put hacktoberfest-accepted label on this, it'll help me a lot

im currently not in great standing with the team and don't have explicit org permissions to do this. However this PR gets an unofficial approval from me, @pocco81 should be able to help you out with the hacktoberfest stuff and merging :)

anuragxone commented 1 year ago

looks fine to me, not tested it though. Since when was sapphire a part of the palette though?

i kinda don't know when, but i was just applying the theme system wide, and discovered that sapphire was missing, if you approve this change can you put hacktoberfest-accepted label on this, it'll help me a lot

im currently not in great standing with the team and don't have explicit org permissions to do this. However this PR gets an unofficial approval from me, @pocco81 should be able to help you out with the hacktoberfest stuff and merging :)

oh okay, @davidbgonz , @backwardspy , @taka0o ?

davidbgonz commented 1 year ago

Lgtm

davidbgonz commented 1 year ago

Thanks for catching that @anuragxone