search

catppuccin / spicetify

🎧 Soothing pastel theme for Spotify
MIT License
469 stars 27 forks source link

Change accent colour to black on the latte colour scheme #60

Closed whoisgrayson closed 10 months ago

whoisgrayson commented 10 months ago

Is there a way to change the accent colour to Black on the Latte colour scheme?

ohitstom commented 10 months ago

Is there a way to change the accent colour to Black on the Latte colour scheme?

there's no black defined in the official palette though

sgoudham commented 10 months ago

@ohitstom can you help me understand why the spicetify theme has a white accent in the first place even though the colour is not part of the official palette?

I was going to initially disagree with adding black but feels even weirder to disallow black when white is already there...

ohitstom commented 10 months ago

@ohitstom can you help me understand why the spicetify theme has a white accent in the first place even though the colour is not part of the official palette?

I was going to initially disagree with adding black but feels even weirder to disallow black when white is already there...

no idea it was here before my rewrite I just kept it in...

sgoudham commented 10 months ago

I'd be tempted to remove white so that the accents provided are only from the official palette, but it feels sort of mean to do that now.

Maybe removing it and adding some extra docs listing the instructions for adding a custom accent and recompiling the theme?

ohitstom commented 10 months ago

I'd be tempted to remove white so that the accents provided are only from the official palette, but it feels sort of mean to do that now.

Maybe removing it and adding some extra docs listing the instructions for adding a custom accent and recompiling the theme?

both colors are from somewhere in the palette but aren't technically accent colors...

It would feel wrong removing them because maybe some people just want the base colors without any accent at all?

Maybe as an alternative I can add an option for no accent color which uses the default text color instead?

idk just throwing some ideas out there!

sgoudham commented 10 months ago

The closest colour that I can find to the existing white is Latte Crust but it's not the same image It looks like you've taken Latte Text to be the black accent in the latest #62 PR.

No accent color option being text sounds good, should that be the default? Are we shipping with a default accent color already?

ohitstom commented 10 months ago

No accent color option being text sounds good, should that be the default? Are we shipping with a default accent color already?

will modify the PR to make the default option no accent when I get some time, that seems like the best approach

ohitstom commented 10 months ago

@sgoudham PR is updated to match the changes you requested! im considering formatting the codebase using prettier, is there rules on how code should be formatted org wide?