catppuccin / sublime-text

🍋 Soothing pastel color schemes for Sublime Text
MIT License
105 stars 14 forks source link

Selection Too Dark #1

Closed karimlevallois closed 2 years ago

karimlevallois commented 2 years ago

The selection colour is a little dark and you cannot see the text under the selection. I have updated mine with "selection": "color(var(gray) alpha(0.20)", so maybe update if you are happy with that.

Many thanks, Karim

karimlevallois commented 2 years ago

I've also added the following to bring it more in line with the Neovim port.

        "gutter_foreground_highlight": "var(green)",
        "line_highlight": "var(black2)"
BrunDerSchwarzmagier commented 2 years ago

I agree that it needs a lower alpha, especially on comments, but 0.2 seemed a bit low to me elsewhere. I just updated it to be 0.4 which looks good on some samples I was looking at. Lmk if you think that's sufficient contrast.

Also good call with the line numbers!

karimlevallois commented 2 years ago

No problem, happy to help out. Will give it a go later. Are you updating the gutter foreground to var(green) too, cannot see that under your commits, unless I've missed it?

karimlevallois commented 2 years ago

I was being stupid, can see it. Sorry about that!