catppuccin / userstyles

🖌 Soothing pastel userstyles
MIT License
530 stars 155 forks source link

GitHub mentions aren't themed #512

Closed Insprill closed 9 months ago

Insprill commented 9 months ago

Is there an existing issue outlining your problem?

What userstyles are you seeing the problem on?

lbl:github

Describe your problem.

The background of mentions doesn't get themed.

Attach screenshots.

image

What browser(s) are you seeing the problem on?

Firefox v122.0.1

Any additional comments?

No response

uncenter commented 9 months ago

Sorry @isabelroses... just for testing.

uncenter commented 9 months ago

Yeah okay just as I had thought. They are themed, but I believe your accent color just happens to look like that and makes you think it isn't themed?

I use the red accent color: Screenshot 2024-02-13 at 11 11 43 (Arc) But with mauve, it looks like the color in your screenshot: Screenshot 2024-02-13 at 11 12 49 (Arc)

isabelroses commented 9 months ago

Yeah okay just as I had thought. They are themed, but I believe your accent color just happens to look like that and makes you think it isn't themed?

i think its the bg

image

EDIT: its due to --color-user-mention-bg

uncenter commented 9 months ago

Huh, there aren't backgrounds on mentions for me... I can't reproduce this but happy to merge a fix if y'all have one.

uncenter commented 9 months ago

Turns out you have to be pinged by someone else to see it, since the background is a highlight that only appears when you yourself are mentioned.