catppuccin / userstyles

🖌 Soothing pastel theme for Userstyles
MIT License
376 stars 111 forks source link

Wikipedia styling issues #803

Open cynanthropy opened 2 months ago

cynanthropy commented 2 months ago

Is there an existing issue for this?

What is your concern?

image Using Mocha theme, but some elements aren't styled (text, the header, sidebar links, etc). I don't have any other styling extensions enabled & am just using the default Vector theme in Wikipedia itself

NK308 commented 2 months ago

On which version of Wikipedia are you? I had issues with other stylus user styles and Wikipedia in the past. In my case, styles usually work on the English Wikipedia, but fail on the German version. I'm not sure, if this is related to your issue, since your screenshot seems to originate from an English version or are you on another subdomain than en.wikipedia.org? If it really is a problem of the different html classes in different versions of wikipedia, it might be a good workaround to restrict the catppuccin user style to that subdomain and then investigate fixes for other subdomains.

cynanthropy commented 2 months ago

Just using en.wikipedia.org. After testing it seems to be an issue only when using the legacy Vector layout, though all layouts except Vector 2022 & MinervaNeue (except popups) are pretty uncomfortable to use. Subdomain doesn't make any difference.

Vector 2022: image

MinervaNeue: image

Timeless: image

MonoBook: image

NK308 commented 2 months ago

How does one choose the layout for wikipedia and most of all, why aren't they the same, depending on the language?

cynanthropy commented 2 months ago

i don't think the language changes the layout. in wikipedia, you choose preferences, -> appearance, -> then you can choose your layout.

NK308 commented 2 months ago

There seems to be an important detail missing in this discussion: I you don't have an account on wikipedia (and most people probably don't) you can't choose a skin for wikipedia. And after I just created an account, the German wikipedia still had the legacy vector skin as default, which isn't even a choice any more on the English wikipedia.

So this issue can be resolved by either putting the workaround "create yourself an account and change the skin" into the userstyle's readme or to modify the css, so that it works for multiple styles. If a css, that works for all available skins, isn't possible, it should at least be attemted to make it work for skins, which are known to be the default on some local wikipedia, which would be Vector 2022 and Vector 2010.

Edit: The skins can appearently be told apart by by the class of the body element. It should be possible to put a lot of body.skin-vector-2022 and body.skin-vector-legacy into the selectors of the css.