catppuccin / userstyles

🖌 Soothing pastel theme for Userstyles
MIT License
376 stars 111 forks source link

GitHub: the header is strictly following the light flavor colors when logged out #954

Closed thismoon closed 1 month ago

thismoon commented 1 month ago

Is there an existing issue outlining your problem?

What userstyles are you seeing the problem on?

lbl:github

Describe your problem.

when browsing github while logged out, the colors of the header are strictly being used from the light flavor. i made a work around that forces using the dark flavor (it will force a dark header while using the light flavor). here's the work around (replace lines 195 to 200 with this):

    --header-fgColor-default: @catppuccin[@@darkFlavor][@text];
    --header-fgColor-logo: @catppuccin[@@darkFlavor][@text];
    --header-bgColor: @catppuccin[@@darkFlavor][@crust];
    --header-borderColor-divider: #8b949e;
    --headerSearch-bgColor: @catppuccin[@@darkFlavor][@mantle];
    --headerSearch-borderColor: @catppuccin[@@darkFlavor][@surface0];
      .header-logged-out{color:@catppuccin[@@darkFlavor][@text]};

this work around doesn't fix everything. some text is still being styled with the light flavor colors therefore being not easily readable this issue isn't present when logged in. also without the catppuccin theme, github uses a dark header by default even when the theme is light

Attach screenshots.

the current userstyle: image the work around: image the work around with light mode: image default github (no theme) with light mode: image

What browser(s) are you seeing the problem on?

Firefox v126.0.1

Any additional comments?

No response

uncenter commented 1 month ago

This is a GitHub problem, as they always have the header when logged out set to that. Not planning to change this.