search

catppuccin / userstyles

🖌 Soothing pastel userstyles
MIT License
471 stars 137 forks source link

ci(issue-labeler): don't add impartial matches #956

Closed uncenter closed 3 months ago

uncenter commented 3 months ago

Fixes an issue with the issue-labeler regex that considers impartial matches - for example, https://github.com/catppuccin/userstyles/issues/930 was given both google and google-drive due to our regex:

Screenshot 2024-06-06 at 09 13 49 (CleanShot)

Using ^ and $ should only match full patterns, though I can't really test this.

isabelroses commented 3 months ago

I see the idea, my only concern is issues that affect two userstyles, though they are a rarity...

uncenter commented 3 months ago

I see the idea, my only concern is issues that affect two userstyles, though they are a rarity...

Any userstyle that involves a word with another userstyle would be at risk... I don't see why not.

isabelroses commented 3 months ago

Any userstyle that involves a word with another userstyle would be at risk... I don't see why not.

I know what your getting at but if we match by ^ and $ we can no longer match lbl:whatsapp-web, lbl:google

uncenter commented 3 months ago

Any userstyle that involves a word with another userstyle would be at risk... I don't see why not.

I know what your getting at but if we match by ^ and $ we can no longer match lbl:whatsapp-web, lbl:google

Fair. Didn't even realize you could select multiple. Then we need a more complicated regex...