search

catppuccin / vim

🧋 Soothing pastel theme for Vim
MIT License
244 stars 15 forks source link

fix: swap guifg & guibg diff colors #13

Closed pbnj closed 1 year ago

pbnj commented 1 year ago

Hello cattppuccin maintainer(s) & users, this PR is a question/idea/suggestion for an aesthetically improved diff highlights for vim (see below for the before/after screenshots).

Let me know if this is accepted and I can apply the change to the rest of the colorscheme files.

Here is the before:

Screenshot 2022-12-21 at 4 30 39 PM

And after:

Screenshot 2022-12-21 at 4 22 25 PM

M3nny commented 1 year ago

This was done because, with plugins like vim-fugitive, you can easily see the diff display, initially it was a bit like your PR, but then it changed with this pull request

pbnj commented 1 year ago

I see.

I personally prefer the foreground over background highlighting, but at this point it's a matter of preferences.

Unless we want to support these use-cases with conditional logic exposed via flag variables (eg g:diff_fg_highlighting = 0|1, g:diff_bg_highlighting = 0|1 ...etc), I don't have a strong opinion either way and will leave it up to others to make a final decision.