search

catppuccin / vim

🧋 Soothing pastel theme for Vim
MIT License
239 stars 15 forks source link

Remove LineNrAbove/Below specific colors #4

Closed maxjcohen closed 2 years ago

maxjcohen commented 2 years ago

Hi, small PR to remove specific values for LineNrAbove and Below, causing relativenumber to appear in fixed (here white) color. By simply removing those lines, vim and nvim fall back to the LineNr value for relativenumber.

M3nny commented 2 years ago

I knew this was a problem, but I thought it was a terminal issue, since for some terminals the colors of the numbers are respected and in others they are white, by removing the lines in your PR anyway I get all gray numbers.

maxjcohen commented 2 years ago

I knew this was a problem, but I thought it was a terminal issue

I tried with Alacritty and st, both seem to work the same way, but can't say for any other terminal.

by removing the lines in your PR anyway I get all gray number

Isn't that the expected look ?

M3nny commented 2 years ago

Nope, the expected look is in the README screenshot, i figured out what is the problem, i'm going to fix it now

M3nny commented 2 years ago

This should work

maxjcohen commented 2 years ago

I think that broke classic numbers (aka no relativenumber) on my end. All line number but the current are blue.

With relativenumber, things look good when cursorlineopt is not set to number (which is part of the default).

M3nny commented 2 years ago

What do you think about it now?

maxjcohen commented 2 years ago

Seems good to me, nicely done.

M3nny commented 2 years ago

Nice