DylanWhite2
commented
4 months ago The sticky scroll bar is also different to the VS Code one. VS has it as a light colour, VS Code as a dark one. Could VS be updated to use the VS Code colour?
Open DylanWhite2 opened 4 months ago
DylanWhite2
commented
4 months ago The sticky scroll bar is also different to the VS Code one. VS has it as a light colour, VS Code as a dark one. Could VS be updated to use the VS Code colour?
djflan
commented
4 months ago I am running Visual Studio Professional 17.10.0 Preview 6.0.
When I turn on any of the themes the editor window theming is updated correctly but the surrounding borders/menus/headers are white. If I enable "Use classic UI control styles (requires restart)" then everything works as expected. Are there any plans to update the theme to accommodate the new UI?
https://devblogs.microsoft.com/visualstudio/the-visual-studio-ui-refresh-preview-is-here/
Thanks!
Support isn't there yet for the new control styles. But we do plan on supporting it. My current VS version doesn't seem to have that as a preview feature. I can't make any promises about when it might come though.
djflan
commented
4 months ago I have relabeled the title - this is technically, a feature request vs a bug.
DylanWhite2
commented
2 weeks ago @djflan this issue is regarding the UI refresh. The sticky scroll is fixed but the new UI is still incompatible (for me anyway)
djflan
commented
2 weeks ago @DylanWhite2 Are you on a VS preview release channel? What does the refresh UI look like with the theme applied? My problem here is that it isn't yet a preview feature in the stable channel, so I don't have a way to actually look at it and make tweaks.
Sounds like we need to revisit this.
DylanWhite2
commented
2 weeks ago Yes, just on the regular preview builds (currently Visual Studio Professional 2022 17.11.0 Preview 1.1)
moonbeeper
commented
2 weeks ago Haha, woopsy from my side! Somehow, I misunderstood your issue as "sticky scroll no worky" when, in fact, it was that the ui refresh that doesn't really work with the theme.
I just fixed that (or at least I think I did) with the recent pull request. Test it out and let me know if there's anything I might have missed!
djflan
commented
2 weeks ago We might need to be careful here, as I understand it the preview builds often contain identifiers that aren't finalized yet. Just a thought because we could spend time working on this and it breaks when the feature goes live in the stable channel.
moonbeeper
commented
2 weeks ago Oh, bongos. You're right, they might swap the identifiers for different ones or just be using these as temporary placeholders to replace later with the original ones (the ones with “color” in the name) when they release the refreshed UI. But hey, at least now we have a rough idea of how the theme would look with the new UI! For now, it might be best to just draft, close or whatever works for my pull request and wait until the stable release.
Ah, and also the author of the issue now has a draft of the theme’s look in the new UI, something is something haha!
I am running Visual Studio Professional 17.10.0 Preview 6.0.
When I turn on any of the themes the editor window theming is updated correctly but the surrounding borders/menus/headers are white. If I enable "Use classic UI control styles (requires restart)" then everything works as expected. Are there any plans to update the theme to accommodate the new UI?
https://devblogs.microsoft.com/visualstudio/the-visual-studio-ui-refresh-preview-is-here/
Thanks!