search

catppuccin / vscode-icons

🦊 Soothing pastel icons for VSCode/VSCodium
https://marketplace.visualstudio.com/items?itemName=Catppuccin.catppuccin-vsc-icons
MIT License
571 stars 26 forks source link

chore: disable prettier for vscode users #200

Closed uncenter closed 2 months ago

uncenter commented 2 months ago

The conflict between Prettier and ESLint Stylistic was causing a lot of errors!

prazdevs commented 2 months ago

I dont think VSC settings belong in a github repository. Maybe specify in the readme or contributing that style is handled by ESLint and it is recommended to use it instead of whatever tool.

uncenter commented 2 months ago

I dont think VSC settings belong in a github repository

You already have https://github.com/catppuccin/vscode-icons/blob/main/.vscode/launch.json and the entire point of being able to have a repository-specific .vscode/settings.json is for stuff like this.

Maybe specify in the readme or contributing that style is handled by ESLint and it is recommended to use it instead of whatever tool.

Hmm well then I'll just have to keep this file floating around untracked anyway to disable Prettier. FYI you can also use this file to turn on ESLint autofix on save, and more.

prazdevs commented 2 months ago

the launch is for the debugger and is independant of whatever config/extensions people are using. could always add the settings.json to the gitignore