catppuccin / vscode

🦌 Soothing pastel theme for VSCode & Azure Data Studio
https://marketplace.visualstudio.com/items?itemName=Catppuccin.catppuccin-vsc-pack
MIT License
1.43k stars 52 forks source link

Customization doesn't work on vscode.dev #261

Closed Master-Hash closed 10 months ago

Master-Hash commented 10 months ago

Reproduce

I set

{
    "catppuccin.accentColor": "teal",
}

in settings.json.

Expect (installed): 图片

Real behavior (vscode.dev): 图片

nekowinston commented 10 months ago

That's sadly a limitation of vscode.dev; Catppuccin should display a notification when changing settings in the Browser version: https://github.com/catppuccin/vscode/blob/fcf17c881741998ec8085554f35b54a3e0834d2e/packages/catppuccin-vsc/src/browser.ts#L10-L16

We can't save the re-compiled theme back into the extension directory, like we're doing in the App version.