search

catppuccin / vscode

🦌 Soothing pastel theme for VSCode & Azure Data Studio
https://marketplace.visualstudio.com/items?itemName=Catppuccin.catppuccin-vsc-pack
MIT License
1.41k stars 50 forks source link

Custom accent color #411

Open mattlucock opened 3 months ago

mattlucock commented 3 months ago

The readme says:

You can choose any color as your "accent" color.

I think what the author meant to say was that you can choose any color from the Catppuccin palette as your accent color. Instead, it says that you can simply choose 'any color'. This is definitely not the case; it's clear from trying it that this doesn't work, and it's clear from the code that this doesn't work.

But I think I would like it to work. I want to use an accent color that isn't one of the options from the palette, and I would be happy to override the accent color in the same way that I'm overriding named colors such as base and mantle. From the code, it's clear that accent is not a named color, but a variable that holds a named color. This strikes me less as an intentional design choice and more as an inadvertent limitation of the current implementation. Given that the theme explicitly allows colors to be overridden, it seems odd and contradictory that the scope for customizing the accent color is so limited. At the very least, I think the documentation should be clarified.

See also #410

uncenter commented 3 months ago

Can you not set the accent color to say pink and then use colorOverrides to change it to a custom hex?

mattlucock commented 3 months ago

I already thought of that. The problem is that I don't know which of the palette colors are being used for syntax highlighting. My uninformed guess would be that they probably all are, and I have no desire to mess with the syntax highlighting. If there is a named color in the palette that is definitely not being used, then I guess that would work, but even so it certainly seems less than ideal.