catppuccin / vscode

🦌 Soothing pastel theme for VSCode & Azure Data Studio
https://marketplace.visualstudio.com/items?itemName=Catppuccin.catppuccin-vsc-pack
MIT License
1.43k stars 52 forks source link

Set `editor.wordHighlightStrongBackground`? #429

Closed prurph closed 1 week ago

prurph commented 2 months ago

It seems like catppuccin does not set --vscode-editor-wordHighlightStrongBackground (found here in the type). This results in use of the default that doesn't match the theme (note the teal background on the function user parameter):

CleanShot 2024-08-20 at 18 44 21@2x

Would it be possible/desirable for the theme to set this color? Out of the box, it is a different color than the regular selection background, however the catppuccin spec doesn't speak to different selection backgrounds based on context, so it's not clear to me whether the appropriate course would be to make it the same as editor.wordHighlightBackground or attempt to differentiate it as VSCode normally does.

sgoudham commented 1 week ago

Hey 👋, Thanks for raising the issue.

Personally, I'm not such a fan of it. I've got some screenshots below where the first two are the same colour as editor.wordHighlightBackground and the last two are trying to make it stand out a tiny bit. I'm curious which one you'd prefer.

Same as editor.wordHighlightBackground `Mocha - opacity(palette.overlay2, 0.2)` ![image](https://github.com/user-attachments/assets/6aeb4e91-64cd-4db6-a2a2-e96dc3ceff57) `Latte - opacity(palette.overlay2, 0.2)` ![image](https://github.com/user-attachments/assets/3295afe0-f8da-44da-882d-383e865a1122)
Very light shade of blue `Mocha - opacity(palette.blue, 0.2)` ![image](https://github.com/user-attachments/assets/195db702-87fe-4af9-bf63-f0dd2516513e) `Latte - opacity(palette.blue, 0.1)` ![image](https://github.com/user-attachments/assets/d4791722-31c7-4932-ad19-1f35dc1cd808)
prurph commented 1 week ago

Thanks for responding! To my eyes both sets of screenshots look good!

My main gripe in raising the issue is that by not setting the variable to something theme appropriate we get that teal-blue background that is the VSCode default and that definitely clashes with the Catppuccin theme IMO.

Both of these adjustments fix that and give a consistent visual style, so I'd be delighted with either.

sgoudham commented 1 week ago

Thanks for the swift reply! (Apologies on my part for how long it's taken me to reply to this one haha)

I've gone with the light shade of blue since I received some feedback on our discord that keeping the colour differentation is good.

It'll be included in the next release!