catppuccin / vscode

🦌 Soothing pastel theme for VSCode & Azure Data Studio
https://marketplace.visualstudio.com/items?itemName=Catppuccin.catppuccin-vsc-pack
MIT License
1.43k stars 52 forks source link

Fix desync between icon pack and color theme #431

Closed younishd closed 2 months ago

younishd commented 2 months ago

The root cause of the problem is that VS Code seems to fire the onDidChangeActiveColorTheme event before the config is persisted, thus our syncToIconPack() runs too early and in turn getActiveTheme() reads back the not-yet-updated theme from the configuration.

The fix is to listen for both the config change and the active theme change (needed to handle the autoDetectColorScheme edge case).

Solves #430.