catppuccin / vscode

🦌 Soothing pastel theme for VSCode & Azure Data Studio
https://marketplace.visualstudio.com/items?itemName=Catppuccin.catppuccin-vsc-pack
MIT License
1.43k stars 52 forks source link

VSCodium workspace accent color doesn't take effect automatically #443

Open akwala opened 4 weeks ago

akwala commented 4 weeks ago

As I understand it, if I set "catppuccin.accentColor": "blue" under Workspace and save the workspace, then the accent color should be blue when I launch VSCodium with the saved workspace as the argument.

However, when I open the saved workspace this way, the accent color in the UI is not blue. Instead, it is the accent color of the last workspace I had opened.

To get the accent color of the opened workspace, I have to

  1. change the workspace's accent color to another color,
  2. then change it back to the correct color (blue),
  3. and reload the window.

(I posted this on Catppuccin's VSCode channel as well as Support over a week ago,)

sgoudham commented 1 week ago

Hey :wave:,

Can you give me more details on this issue so that I can try to reproduce? I'd appreciate the following:

Thanks!

backwardspy commented 1 week ago

@sgoudham and I have spent some time investigating this and the source of the issue seems to be that our theme supports customisation. this is not something that vscode handles natively - we have to do quite a lot of work to take the user's customisation options and dynamically rebuild the theme with them. this is why you have to reload the window after changing customisation options for them to take effect.

the official method for doing this is to not provide customisation settings at all and instead ship a collection of static themes you can choose from in the colour theme menu in vscode. unfortunately we provide far too many customisation options for this to be a feasible solution for us. we would have to ship hundreds of variants of the theme just to support all combinations of the most common customisation options (flavour, accent colour, italics.) to support all of the features we have now is simply unrealistic.

as of now we have no good solution for making this work in a per-workspace manner. we will continue to investigate and see if there is any kind of workaround we can provide for this use case.

akwala commented 1 week ago
* Version of VSCodium

Current VSCodium version info: Version: 1.95.2 Release: 24313 Commit: 7656a0bea17ba6cf301721572e10c9035bb378e6 Date: 2024-11-08T18:21:12.757Z Electron: 32.2.1 ElectronBuildId: undefined Chromium: 128.0.6613.186 Node.js: 20.18.0 V8: 12.8.374.38-electron.0 OS: Linux x64 5.15.0-125-generic

* Version of the Catppuccin Extension

v3.15.2

* The command & arguments you used to launch VSCodium

/path/to/codium --profile <profile_name> /path/to/<project_name>.code-workspace

* You mention that you saved the settings under a Workspace, do you mean setting it in `.vscode/settings.json` for a given directory?

Settings saved in *.code-workspace file.