catppuccin / windows-files

šŸŖ Soothing pastel theme for Windows Files
MIT License
112 stars 4 forks source link

Custom theme support removed in Files 2.4.21 #7

Closed lbux closed 8 months ago

lbux commented 1 year ago

The option to add custom themes through files was removed as noted in several GitHub issues:

https://github.com/files-community/Files/issues/10315 https://github.com/files-community/Files/issues/10542 https://github.com/files-community/Files/issues/10885

The updated documentation suggests some ways to customize it to an extent. Is there any way to integrate catppuccin to this new version?

CaidenBlock commented 1 year ago

According to the docs, the only thing you can do is change are background colors, all accents are based off of windows theme color.

CharlesChiuGit commented 1 year ago

Sad to see this. šŸ˜¢

Only-Moon commented 1 year ago

Shouldn't this repo be archived since it can be applied anymore?

Only-Moon commented 1 year ago

Shouldn't this repo be archived since it can be applied anymore?

Aworldc commented 11 months ago

Got it working!

{
  "AppThemeBackgroundColor": "#ff232634",
  "AppThemeAddressBarBackgroundColor": "#ff292c3c",
  "AppThemeSidebarBackgroundColor": "#ff292c3c",
  "AppThemeFileAreaBackgroundColor": "#ff303446"
}
image
thiphariel commented 10 months ago

Got it working!

{
  "AppThemeBackgroundColor": "#ff232634",
  "AppThemeAddressBarBackgroundColor": "#ff292c3c",
  "AppThemeSidebarBackgroundColor": "#ff292c3c",
  "AppThemeFileAreaBackgroundColor": "#ff303446"
}
image

@Aworldc Hi! How did you manage to do it? My settings file got erased (manual changes) after every restart... Thanks :-)

Ok well, I just had to disable the background running task... Sorry for that! And thanks for the theme tip :-) Can confirm it still "works"

yaira2 commented 9 months ago

According to the docs, the only thing you can do is change are background colors, all accents are based off of windows theme color.

@CaidenBlock the current options are based on the brushes that users were customizing in the previous theming system, but we can add more options if there is enough interest.

DakshG07 commented 9 months ago

@yaira2 it would be quite nice if additional options were available. The themeā€™s 80% there, but it would be great if we could really theme everything. Was there a specific reason to limit theme functionality? In my opinion, the more customization options, the better.

Also, Iā€™ll test out the new theme methods and update this repository sometime today or tomorrow.

yaira2 commented 9 months ago

The previous system worked by loading xaml into the app at startup and overriding the default brushes in Files. This was a good idea in theory, but in actuality we found it had an impact on startup performance, the syntax was too complex for most users, and was prone to breaking whenever we released updates to Files. On the flip side, the current theming system uses json, has good performance, and doesn't have any issues when the app is updated.