search

catppuccin / windows-terminal

🪟 Soothing pastel theme for Windows Terminal
MIT License
479 stars 22 forks source link

Remove accented e for alignment with frappeTheme.json #14

Closed adamjames closed 1 year ago

adamjames commented 1 year ago

Wasn't sure whether to add it in here or remove it - I went with remove since none of the other files use accented letters.

Fixes Powershell falling back to the default when trying to use Frappe.

justTOBBI commented 1 year ago

Can't replicate the issue in the first place. Works on my machine xd

adamjames commented 1 year ago

How odd! Let me reconfirm, I could have made a mistake :)

On Sat, 3 Jun 2023 at 14:44, justTOBBI @.***> wrote:

Can't replicate the issue in the first place. Works on my machine xd

— Reply to this email directly, view it on GitHub https://github.com/catppuccin/windows-terminal/pull/14#issuecomment-1574959695, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGAP5ZINB5VB3NUKWWXTULXJM5UNANCNFSM6AAAAAAYZI66J4 . You are receiving this because you authored the thread.Message ID: @.***>

justTOBBI commented 1 year ago

Sorry, issue on my side. I forgot that I changed the name of my theme. If it's broken for you, its most likely broken for everyone.

adamjames commented 1 year ago

Fair enough then :) I double-checked this once more and I'm happy that it's just the accented e that needed adjusting. Are we okay to merge?