catppuccin / zed

🦀 Soothing pastel theme for Zed
MIT License
214 stars 10 forks source link

inlay hints are a visual distractor #19

Closed kynnyhsap closed 4 months ago

kynnyhsap commented 4 months ago

i use catppuccin mocha theme in zed and when i tried to enabled inlay hinds i noticed that they are just a regular white color indistinguishable from variables, which makes it hard to read the code because i can't what what is type annotated manually and what is not

code without inlay hints

Screenshot 2024-04-30 at 12 13 28

code with inlay hinds

Screenshot 2024-04-30 at 12 13 33

in the intelliji they look like a badge or a faded comment, i prefer the grayish comment style inlay hints.

Screenshot 2024-04-30 at 12 16 18
tecandrew commented 4 months ago

oh interesting, thanks for submitting this issue. I see it on my end as well: I normally don't enable this feature.

will investigate how I could fix this. the built in Zed Syntax debug tree doesn't give a hint as to what colors this 😅

image

tecandrew commented 4 months ago

One Dark and Dracula theme seem to have this colored correctly. this should be an easy fix

image

image

tecandrew commented 4 months ago

found a fix, but also noting down some strange behavior with how inlay_hints are colored by default from Zed:

hint: affects both inlay_hints and the git blame coloring. the inlay_hints color doesn't respond well to defined hex alpha values to reduce opacity, but the git blame stuff does 🤔

image

ref: https://github.com/zed-industries/zed/issues/11220

kynnyhsap commented 4 months ago

sick! thank you @tecandrew !!!