catppuccin / zed

🦀 Soothing pastel theme for Zed
MIT License
212 stars 10 forks source link

Insufficient contrast between selection and highlight #5

Closed joeldrapper closed 6 months ago

joeldrapper commented 6 months ago

With my eyes, I can’t tell the difference, at a glance, between selected text and highlighted symbols. In this screenshot, for example, the third node is selected, while the other four are just highlighted.

Screenshot 2024-03-07 at 10 21 19

This is particularly confusing when trying to work with multiple cursors.

Here’s a closer look. In this screenshot opt is selected, while the rest of the word options is just highlighted because it’s the active symbol.

Screenshot 2024-03-07 at 10 25 32
tecandrew commented 6 months ago

@joeldrapper this is a more of a problem with Zed editor itself and have brought this up before 😅

https://github.com/zed-industries/zed/issues/8316

https://github.com/zed-industries/zed/issues/7448

I found some themes are better at it than others, but it's still low-contrast.

joeldrapper commented 6 months ago

Oh that’s interesting. I thought there was a way to specify the selection colour. Some themes have a selection color that's different from the active symbol highlight color.

tecandrew commented 6 months ago

Zed has some interesting behaviors with what is affected by tweaking these parameters. I'll see if I could find a good middle ground solution for keeping the Catppuccin colors and adjusting for better standout contrast.

image

I'm finding that VS Code overrides the current auto-select with the "selection highlight" color, while Zed just maintains the read_background param and not accommodate for selection color. image

tecandrew commented 6 months ago

Zed Ayu Dark (default theme) seems to have a good solution, so I'll replicate this behavior

image