search

catppuccin / zen-browser

🧘‍♂️ Soothing pastel theme for Zen Browser
MIT License
36 stars 1 forks source link

feat: container tabs styling #18

Closed 42willow closed 6 days ago

42willow commented 6 days ago

Current: image

After: image

(note: this popup menu is unthemed as of latest commit (see below) but the container tabs and the main menu is)

I was having trouble with styling userContent as I didn't know which selector to use specific to the page. It's probably a better idea to put the styles under @-moz-document url-prefix("about:preferences") but then the popup won't be themed :/

please let me know if you think you know a way to theme the contents of the multi-account container popup

42willow commented 6 days ago

@IAmJafeth just letting you know, this will PR also format the indentation to 2 spaces as that is standard for catppuccin (see .editorconfig) - userContent.tera was indented with 2 spaces while userChrome.tera was indented with 4

uncenter commented 6 days ago

In the future I would suggest splitting formatting PRs from functional PRs to simplify the reviewing process, fyi.

IAmJafeth commented 6 days ago

Hey @42Willow !

Thanks for the nice addition and for helping with the formatting. Just as uncenter said, it will be very helpful to separate Feature and Formatting to have a cleaner diff review, but excellent job!

Regarding your question for the multi-account container popup theming, I will need some time to thinker with it as it is a feature I do not use much, feel free to open an Issue and we can track it there!