search

catseye / The-Swallows

Novel-generator and generated novels for NaNoGenMo 2013
http://catseye.tc/node/The%20Swallows
Other
34 stars 6 forks source link

Need examples of adding locations and objects #2

Closed MichaelPaulukonis closed 11 years ago

MichaelPaulukonis commented 11 years ago

The sample files could use examples of adding locations and objects to extend the default world.

catseye commented 11 years ago

Cool, ok, I'm slightly confused, because I didn't know that you could reference an issue on Github from a commit in a fork -- but, ok, I guess forks share their issues. It made it look kind of like there was a pull request on this issue, but there doesn't seem to be one.

Did you mean to submit a pull request for your changes?

If so, I guess I should sort out the licensing first, which I've been procrastinating on.

I think I'd like the files in eg/ and src/swallows/engine to be public domain. The story world itself, I will probably make open-source at some point after November has passed, but I'd like to wait on that.

Are you OK with putting your changes to eg/the_swallows++.py into the public domain?

MichaelPaulukonis commented 11 years ago

I am OK with putting my changes to eg/the_swallows++.py into the public domain.

This is actually my first pull-request on somebody's project (oh!), and was done using notes here: http://stackoverflow.com/a/7189981/41153

I'd sure like to do it "the right way" but @#@#$ if I could figure it out yesterday.

catseye commented 11 years ago

Ah, I see. Yeah, I've never figured out how to attach a pull request to an existing issue; I just gave up trying. I usually just create a new pull request, which creates a new issue, then update the old issue to reference the new issue. (In any big project there will be some duplicate issues anyway, so this never worried me much.)

That stackoverflow advice doesn't seem to work, or at least, didn't work in this case, as I can't see any pull requests for this repo. I'll see if I can make a pull request from your fork myself, and merge it...

catseye commented 11 years ago

It worked! And I guess you don't have to update the old issue to reference the new issue, if you just reference the old issue from the new (pull request) issue, since github does the cross-referencing for you.

Thank you for your contribution to the Textularity :)

MichaelPaulukonis commented 11 years ago

Also -- seems I was wrong, I did submit a pull-request about five-months back. And I did it differently. hunh.