catskull / GB-Logo-Generator

Online Gameboy logo rom creator utility
http://catskull.net/GB-Logo-Generator/
GNU General Public License v3.0
39 stars 3 forks source link

Allow uploading #19

Closed catskull closed 8 years ago

catskull commented 8 years ago

Allow uploading of a rom to edit it's header.

Upload a rom.

Populate the fields based on the header information.

Remove the load button from the logo and replace it with a fix button that will reset the logo to the nintendo one.

If they've drawn a new logo warn them that the rom will not boot.

catskull commented 8 years ago

This rom. If I change the name, download it, then re-upload, the cartridge type and rom size change.

Rocket Man (Demo) v1.0.gb.zip

electr0sheep commented 8 years ago

This, and other things were fixed in the latest commit: e13c34d6299a8a95836c3c9d7789a562b55907c0

The problem is the ASCII character 00h which is the null character (but yet still a character). I changed the manufacturer and the new lisencee code to show NULL and NA when this occurs. However, there may be other issues regarding this 00h charcter.