In voting page, wallet login is not enforced

cattermelon-xyz / syncvote

Code base for SyncVote App

https://www.syncvote.com/

3 stars 0 forks source link

In voting page, wallet login is not enforced #550

Open limoncanvas opened 8 months ago

limoncanvas commented 8 months ago

Describe the bug Any voting page opened from extension required wallet connect but user can close the modal and continue

Expected behavior Any voting page opened from extension required wallet connect and user should not able to continue without finishing connecting wallet

User can choose one wallet from:

Metamask Phantom Then user can vote using one of those identity

0xk2 commented 8 months ago

Flow:

Open the page -> show "Welcome to Syncvote" modal. If user connected wallet -> do not show. -> Show extension modal if needed (not desire)
Click "connect wallet" -> close "Welcome to Syncvote" modal -> connect

limoncanvas commented 8 months ago

The close button of the modal "Welcome to Syncvote" still appear which allows user to close the modal without connecting wallet
Trong trường hợp checkpoint sử dụng voting machine là document input, màn hình này đang không hiển thị modal yêu cầu connect wallet (expected: cần hiển thị modal connect wallet ở trong tất cả các trường hợp mà user chưa connect wallet)