search

catthehacker / docker_images

Docker images
MIT License
212 stars 75 forks source link

Add $HOME/go/bin to $PATH #106

Closed prologic closed 1 year ago

prologic commented 1 year ago

Fixes #105

prologic commented 1 year ago

I'm not shure about doing stuff, GitHub Hosted Runner Images don't do.

All in all act and it's default images are to help creating workflows for GitHub Actions (not Gitea Actions)

GITHUB_PATH can add entries like this at job level.

Wel even so, This particular flavor of this Image is used by Gitea Actions and Gitea folks, because Gitea Actions chose to support Go as a first-class language for writing custom actions.

Further, adding to the $PATH really doesn't change the runner's behavior much, in fact it just helps improve things and removes an unnecessary step everywhere.

IMO even if Github Actions runners (I don't really use Github myself much) did include the Go compiler, they should include $HOME/go/bin in the $PATH for the very same reason!

ChristopherHX commented 1 year ago

Due to less than 50 downloads of the current version, I think yeah we can merge this, it is not widely used at all.

Some month ago, the go cmd was not even in the `PATH

arm64 builds should also be available soon.

This particular flavor of this Image is used by Gitea Actions and Gitea folks

Cannot be much people using this special image, or did everyone using Gitea Actions use ancient images due to disabled pulling of image updates in act_runner.

I only saw that act-* tags are used (src Discord/Gitea) and that image has much more download stats than go-*.