search

catthehacker / docker_images

Docker images
MIT License
222 stars 78 forks source link

Add Java Build Tools #36

Closed twobiers closed 2 years ago

twobiers commented 2 years ago

I'm currently adopting GitHub Actions to some Java Repositories and would like to use act for locally testing the workflows. However, the provided medium images do not cover the Java build tools - especially Maven in my case.

Is it possible to add another image which contains the three popular build tools Ant/Maven/Gradle? See Java tools by the actual runner: https://github.com/actions/virtual-environments/blob/main/images/linux/scripts/installers/java-tools.sh

Additional Context:

Normally it wouldn't be a problem since the Maven wrapper script can be used. However, windows and docker with WSL backend does not allow this using act, since act will copy the project files without the executable flag on the wrapper (well ofc, it's windows - where should the flag be?). As a workaround you could use -b to bind the project folder as a volume, but doing so, the CRLF line ending from windows will cause issues in the wrapper script.

twobiers commented 2 years ago

Seems like the Java Tools are available since 2615f18d2a623457ef63a98bdc0891c83bffeab2. Guess I can close this issue now, thank you @catthehacker